Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.51%. Comparing base (1265304) to head (d6a4dcb).
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #1399   +/-   ##
=======================================
  Coverage   12.51%   12.51%           
=======================================
  Files         239      239           
  Lines       35942    35942           
  Branches     4076     4076           
=======================================
  Hits         4498     4498           
  Misses      31440    31440           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GeorgeWeb I am just planning implementing the suggestion here: #1491 (comment)
which will I think make this implementation inconsistent because interop events will then have the possibility of having an associated native queue when instantiated with make_event interface that takes a native queue (e.g. stream). Although an error message may still be required since the existing make_event interface will still exist that doesn't take a native queue. So the check such I guess then be that the queue associated with the event is not null, rather than the check for ownership?

@alexbatashev FYI

@GeorgeWeb I am just planning implementing the suggestion here: #1491 (comment)

which will I think make this implementation inconsistent because interop events will then have the possibility of having an associated native queue when instantiated with make_event interface that takes a native queue (e.g. stream). Although an error message may still be required since the existing make_event interface will still exist that doesn't take a native queue. So the check such I guess then be that the queue associated with the event is not null, rather than the check for ownership?

@alexbatashev FYI

@JackAKirk That sounds like a plan. I'll update this error on nullptr queue instead.

@oneapi-src/unified-runtime-maintain just a ping to have a look as that's been stale for some time. Thanks!